Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SheetAttributeMissingException for RawRow and RawSubrow #97

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Fix SheetAttributeMissingException for RawRow and RawSubrow #97

merged 1 commit into from
Nov 3, 2024

Conversation

Haselnussbomber
Copy link
Contributor

For the new RawRow and RawSubrow structs, ExcelModule.GetSheet is throwing SheetAttributeMissingException:

Lumina/src/Lumina/Excel/ExcelModule.cs

Lines 85 to 86 in 2ce372a

var attr = GetSheetAttributes( typeof( T ) ) ?? throw new SheetAttributeMissingException( null, nameof( T ) );
name ??= attr.Name ?? throw new SheetNameEmptyException( nameof( name ) );

Adding SheetAttribute to these structs makes them usable.

@NotAdam NotAdam merged commit f96f062 into NotAdam:master Nov 3, 2024
2 checks passed
@Haselnussbomber Haselnussbomber deleted the fix-rawrow-sheet-attribute-missing branch November 3, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Haselnussbomber @NotAdam